Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two top level objects: kubernetes and tls. #132

Merged
merged 6 commits into from
Oct 1, 2018

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Oct 1, 2018

As discussed in last week's meeting, we're removing these two top level objects.
They may re-appear later as a third level object (whatever comes after Core and
Extended) or as more generic / less product-centric objects.

@ruflin
Copy link
Member

ruflin commented Oct 1, 2018

Can we put these two into a kubernetes use case and a tls use case? This will make it very easy to revive the fields if needed.

@ruflin
Copy link
Member

ruflin commented Oct 1, 2018

@ph @exekias FYI

@webmat webmat mentioned this pull request Oct 1, 2018
26 tasks
@webmat
Copy link
Contributor Author

webmat commented Oct 1, 2018

I've added them both back as use cases. Same exact field list, I've added more concrete examples for fields for kubernetes, but that's all.

First time I spend time in the use cases. Love how the existing ECS field default values get pulled in automatically :-)

Ready for review again.

@ruflin
Copy link
Member

ruflin commented Oct 1, 2018

Can you update the CHANGELOG?

@@ -436,36 +436,6 @@
}
}
},
"kubernetes": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adriansr This might have an effect on the ecs.yml we use in Beats.

@webmat
Copy link
Contributor Author

webmat commented Oct 1, 2018

Ah yes, sorry about the changelog :-)

@webmat webmat merged commit 591a93b into elastic:master Oct 1, 2018
@webmat webmat deleted the remove-2-tlo branch October 1, 2018 18:34
@exekias
Copy link

exekias commented Oct 1, 2018

Does this mean we should rename any of the kubernetes fields in Filebeat / Metricbeat?

@ruflin
Copy link
Member

ruflin commented Oct 1, 2018

@exekias No. They will probably show up in ECS again in the near future it's just not clear yet what we will call this. They are still in the use cases covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants