Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cloud region and AZ field descriptions #1452

Merged
merged 4 commits into from Jun 7, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jun 3, 2021

Expand the field definitions for cloud.region and cloud.availability_zone to include services or resources. The current definition implies these fields are limited to hosts/VMs running in an IaaS service like EC2 or GCE.

Closes #1287

@ebeahan ebeahan added the 1.11.0 label Jun 3, 2021
@ebeahan ebeahan self-assigned this Jun 3, 2021
@ebeahan ebeahan requested a review from a team June 3, 2021 22:49
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ebeahan ebeahan merged commit b9ffdef into elastic:master Jun 7, 2021
@ebeahan ebeahan deleted the improve-cloud.region-description branch June 7, 2021 14:30
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jun 7, 2021
* improve region and az descriptions

* artifacts

* changelog
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
ebeahan added a commit that referenced this pull request Jun 7, 2021
* improve region and az descriptions

* artifacts

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve cloud.region field description
2 participants