Ensure doc_values parameter is passed into Beats field defintions
#1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Planning to backport to |
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jun 30, 2021
…lastic#1488) * add doc_values to parameter allow list * update beats artifacts * add beats generator unit testing * linting * additional artifacts * changelog
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jun 30, 2021
…lastic#1488) * add doc_values to parameter allow list * update beats artifacts * add beats generator unit testing * linting * additional artifacts * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc_valuesshould be set in the Beat field definition artifacts if the parameter is listed on a field's definition.This change adds
doc_valuesinto the Beats generator allow list (allowed_keys).Also adds basic unit testing for portions of the Beats generator module.
Closes #1482