Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 2 changes for RFC 0002 - service.environment #1541

Merged
merged 5 commits into from
Jul 29, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jul 28, 2021

Adding service.environment field as beta to the schema: RFC 0002.

Docs preview

Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ebeahan !
LGTM, but I rather @exekias takes a look as well.

@eyalkoren eyalkoren requested a review from exekias July 29, 2021 05:59
@ebeahan ebeahan merged commit a5fb55d into elastic:master Jul 29, 2021
@ebeahan ebeahan deleted the rfc/0002/stage-2-changes branch July 29, 2021 16:06
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jul 29, 2021
* add service.environment

* adjusting description

* adding artifacts

* adding beta marker

* changelog entry
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
ebeahan added a commit that referenced this pull request Jul 29, 2021
* add service.environment

* adjusting description

* adding artifacts

* adding beta marker

* changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants