Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event.start and event.end #185

Merged
merged 1 commit into from Nov 28, 2018

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Nov 21, 2018

event.start and event.end are date fields that demarcate the beginning and end, respectively,
of an activity. For example in a network flow the event.start is the time of the first packet in the
flow and event.end time the time of the last observed packet in the flow.

The event.duration value is then computed as the difference between end and start times.

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry?

fields.yml Outdated
@@ -491,6 +494,20 @@

In case the two timestamps are identical, @timestamp should be used.

- name: start
level: core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to put both these values in extended for now

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but agree that they should be introduced as extended first.

`event.start` and `event.end` are date fields that demarcate the beginning and end, respectively,
of an activity. For example in a network flow the event.start is time time of the first packet in the
flow and `event.end` time the time of the last observed packet in the flow.

The `event.duration` value is then computed as the difference between end and start times.
@andrewkroh
Copy link
Member Author

Updated with:

  • Fields are now extended.
  • CHANGELOG entry added.

@ruflin ruflin merged commit 394a8cc into elastic:master Nov 28, 2018
MikePaquette pushed a commit to MikePaquette/ecs-1 that referenced this pull request Dec 4, 2018
`event.start` and `event.end` are date fields that demarcate the beginning and end, respectively,
of an activity. For example in a network flow the event.start is time time of the first packet in the
flow and `event.end` time the time of the last observed packet in the flow.

The `event.duration` value is then computed as the difference between end and start times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants