Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify host definition #195

Merged
merged 4 commits into from Dec 5, 2018
Merged

Clarify host definition #195

merged 4 commits into from Dec 5, 2018

Conversation

MikePaquette
Copy link
Contributor

Updated the definition of host at the start of the host section.

ruflin
ruflin reviewed Nov 29, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
tsg
tsg reviewed Nov 29, 2018
View reviewed changes
fields.yml Outdated Show resolved Hide resolved
webmat
webmat suggested changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos to fix:

  • capitalization in product names
  • Singular "Host" in "Host types"

Also, I would be inclined to streamline the host definition for now and not mention devices, as this is all about to change anyway.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MikePaquette MikePaquette force-pushed the host-mods branch 2 times, most recently from 9ca3ee5 to d4a4cce Compare December 4, 2018 22:38
@MikePaquette
Copy link
Contributor Author

I unintentionally corrupted this PR with additional device changes. Going to close it and start this one over.

@MikePaquette MikePaquette reopened this Dec 5, 2018
webmat
webmat approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikePaquette MikePaquette merged commit ecee038 into elastic:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg left review comments

@ruflin ruflin ruflin left review comments

@webmat webmat webmat approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikePaquette @webmat @tsg @ruflin