Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Stage 3 for volume device #2279

Merged
merged 9 commits into from
Dec 13, 2023
Merged

[RFC] Stage 3 for volume device #2279

merged 9 commits into from
Dec 13, 2023

Conversation

Trinity2019
Copy link
Contributor

@Trinity2019 Trinity2019 commented Sep 24, 2023 •
edited
Loading

Stage3 Criteria:

  • Opened pull request for this candidate revising the existing candidate
  • Included multiple real world example source documents
  • Existing or newly raised questions and concerns are addressed
  • No objections from sponsor, ECS team, or subject matter experts

@Trinity2019 Trinity2019 changed the title stage3 commit [RFC] Stage 3 for volume device Sep 24, 2023
@Trinity2019 Trinity2019 marked this pull request as ready for review October 4, 2023 06:34
@Trinity2019 Trinity2019 requested a review from a team as a code owner October 4, 2023 06:34
stanek-michal
stanek-michal approved these changes Oct 6, 2023
View reviewed changes
Copy link

@stanek-michal stanek-michal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trinity2019
Copy link
Contributor Author

@ebeahan Can we get review from ECS team and merge this PR? Thanks in advance!

@Trinity2019 Trinity2019 merged commit 742d005 into elastic:main Dec 13, 2023
3 checks passed
@Trinity2019 Trinity2019 deleted the device-stage3 branch December 13, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

@stanek-michal stanek-michal stanek-michal approved these changes

@ricardoungureanu ricardoungureanu ricardoungureanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Trinity2019 @ebeahan @stanek-michal @ricardoungureanu