Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Stage 0: Introducing LLM fields #2337

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

susan-shu-c
Copy link
Member

@susan-shu-c susan-shu-c commented Apr 26, 2024

Overview

This RFC proposes LLM fields, with the increase of Generative AI and LLM logging. This will benefit our customers and users, allowing them to monitor and protect their LLM/Generative AI deployments.

Update 1: Mika and I have kicked off conversation with the OTel LLM working group; and will proceed there first. We will supersede this PR with an OTel PR; then loop back to this ECS PR again.

Update 2: Opened OTel discussion issue here

Checklist

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@susan-shu-c susan-shu-c requested a review from a team as a code owner April 26, 2024 15:29
@mjwolf
Copy link
Contributor

mjwolf commented Apr 26, 2024

Hi @susan-shu-c, with Elastic's donation of ECS to Open Telemetry, we're going to start adding new features to Open Telemetry first, and then backport changes into ECS. You can find more details about this here.

There's an Open Telemetry LLM working group which has already added some OTel schemas for LLMs. Could you consider getting involved with the OTel working group to add these fields?

@peasead
Copy link
Contributor

peasead commented Apr 29, 2024

@susan-shu-c I'd like to be a part of the discussions. I see that they're using a genai.* fieldset and I think we may want to have discussions with OTel about llm.* being a top-level field, with genai.* being nested under, along with other categories.

@trisch-me
Copy link
Contributor

@peasead FYI Otel currently has no option to "embed" namespaces into each other like we do in ECS. But it is planned to be implemented ASAP.

Currently it will mean that there will be direct dot notation in namespace, llm.gen_ai.*

@susan-shu-c
Copy link
Member Author

There's an Open Telemetry LLM working group which has already added some OTel schemas for LLMs. Could you consider getting involved with the OTel working group to add these fields?

Will participate in some WG meetings; the next on on May 1.(shoutout to @trisch-me for advising). Will edit this PR accordingly

@peasead
Copy link
Contributor

peasead commented Apr 30, 2024

@susan-shu-c I'd like to be a part of the discussions. I see that they're using a genai.* fieldset and I think we may want to have discussions with OTel about llm.* being a top-level field, with genai.* being nested under, along with other categories.

Just to close the loop on this, I misunderstood the AI hierarchy. My original comment was incorrect and should be disregarded.

@susan-shu-c
Copy link
Member Author

Update: Mika and I have kicked off conversation with the OTel LLM working group; and will proceed there first.

@susan-shu-c susan-shu-c marked this pull request as draft May 3, 2024 15:47
@susan-shu-c
Copy link
Member Author

Update 2: Opened OTel discussion issue here

@trisch-me
Copy link
Contributor

I agree with the comment in the otel issue that for such larger submissions the better way is to split it into subgroups.
There will be most probably long debates about naming and definitions so it's much easier for small submissions to get in faster. Also if you see these things are happening - don't be afraid to split submission again and extract those fields into separate PR/issue. Sometimes we are adding just 1 field if it's controversial enough to get into hot discussions

@peasead
Copy link
Contributor

peasead commented May 8, 2024

Hey @susan-shu-c is there anything I can do to help around gen_ai.threat.* fields?

I saw that one of the responses was to break the areas into different issues and PRs. I know that these can be intense, so if there is anything I can help with regarding the threat fieldset, please let me know.

Copy link

github-actions bot commented Jul 8, 2024

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants