Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify host definition wording #325

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

MikePaquette
Copy link
Contributor

WAS: "ECS host.* fields should be populated with details about the host on which the event happened, or on which the measurement was taken."

NOW: "ECS host.* fields should be populated with details about the host on which the event happened, or from which the measurement was taken."

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikePaquette MikePaquette merged commit b9c3640 into elastic:master Feb 15, 2019
webmat pushed a commit to webmat/ecs that referenced this pull request Mar 5, 2019
webmat pushed a commit to webmat/ecs that referenced this pull request Mar 5, 2019
webmat added a commit that referenced this pull request Mar 5, 2019
Backport of PR #325 to 1.0 branch.

The actual fix accidentally got introduced in another backport, so this is only adding the changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants