Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename geoip.* to geo.* fields #58

Merged
merged 4 commits into from
Aug 3, 2018
Merged

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jul 30, 2018

Renaming the geoip prefix to geo based on the discussion in #50

@ruflin ruflin added the review label Jul 30, 2018
@ruflin ruflin mentioned this pull request Jul 30, 2018
The Elasticsearch geoip plugin can do the conversion
to geoip.
Geo fields can carry data about a specific location related to an event
or geo information for a ip field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/a ip/an IP/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Renaming the `geoip` prefix to `geo` based on the discussion in elastic#50
@ruflin
Copy link
Member Author

ruflin commented Aug 2, 2018

@andrewkroh IP fixed and also renamed geoip.yml to geo.yml. I realised this was missing.

@andrewkroh andrewkroh merged commit 75a0ff4 into elastic:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants