Marks items as arrays if required. #661
Conversation
This is to aid code generation for languages that support array constructs. Note: This field is optional, the default value is false. Lack of field presence implies a value of false.
|
Thanks for getting this started, @codebrain. This will be useful. :-) |
|
@codebrain If you don't mind I'll take over the PR from here. That was the plan, right? 🙂 I'll change the way we're specifying what's an array to something like: normalize:
- arrayFor now I will not add more under The purpose of this PR is still 100% focused on clarifying what's an array, however. So:
|
|
Not quite ready to update this PR yet, but I've started work on adapting it here https://github.com/webmat/ecs/commits/is-array-markers, if you want to check it out, @codebrain |
|
webmat@843e521 - looks good. I didn't realise, but it looks as if there are more arrays. I will wait for this to be merged in and then tweak our generator for 1.3. Thanks Mat, yes, more than happy for you to pick this up from here on in :) |
|
@webmat do you know if there's a target release for webmat@843e521 to be incorporated into master? I use ECS for a system that tees logs into Elasticsearch and parquet files and have been maintaining a separate manifest of which fields should be treated as arrays in the parquet schema. |
|
@jeskew We can't make any promises on the release of this branch. But it's towards the top of the list of priorities, as many folks need this, like you do. I'm hoping it will make it into the next ECS release. Note also that merging something to master doesn't make it official. The master branch is a development branch. Only the releases make new developments official 😉 |
Lucene treats all fields as lists, so Elasticsearch/ECS's schema IDL does not distinguish between fields that should be lists and those that should not. This distinction matters for everything not based on Lucene indices. Until elastic/ecs#661 lands in an official ECS release, the model builder will identify which fields should be rendered as Smithy lists based on an internal manifest.
This is to aid code generation for languages that support array constructs.
Note: This field is optional, the default value is false. Lack of field presence implies a value of false.