Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark which fields should be arrays. #727

Merged
merged 23 commits into from
Feb 6, 2020
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a6c6ba7
Marks items as arrays if required.
codebrain Dec 2, 2019
524012a
Merge branch 'master' into is-array-markers
Dec 3, 2019
bbf8b42
Add `normalize:` to schemas/readme.md...
Dec 3, 2019
843e521
Mark all fields that come to mind as arrays, with the new attribute
Dec 3, 2019
14f68ec
Space. The final frontier.
Dec 3, 2019
1333792
Run make
Dec 3, 2019
13fd941
Merge branch 'master' into is-array-markers
Jan 13, 2020
7ffb59a
Pluralize observer addresses. They are legion.
Jan 13, 2020
d935848
Add a sanity check that all fields under 'relate.*' are arrays
Jan 13, 2020
2ef945f
Add a note to asciidoc on fields that should be arrays...
Jan 17, 2020
e8bab5e
Code format
Jan 17, 2020
d0611b1
changelog
Jan 17, 2020
2339531
Default field's 'normalize' setting to [], so we can depend on its pr…
Jan 17, 2020
2433b8b
Add 'Normalization' column to the CSV, to make this easier to review
Jan 17, 2020
9bceb90
Add empty normalization column in csv, for multi-fields
Jan 17, 2020
c5025b6
Put normalization column before example column
Jan 17, 2020
ca3194b
Fix tests around defaults
Jan 17, 2020
b100f00
Fix incorrect attribute name to make file.attribute an array
Jan 17, 2020
15477c2
Don't make error.message an array field
Jan 17, 2020
3cf157f
Adjust user.id definition, I don't think this makes sense as an array
Jan 17, 2020
d0f0c16
Merge branch 'master' into is-array-markers
Jan 31, 2020
26f2255
Add the new empty `normalize` array to a recently added test
Jan 31, 2020
a6df3de
Merge branch 'master' into is-array-markers
Feb 5, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Thanks, you're awesome :-) -->
#### Improvements

* Temporary workaround for Beats templates' `default_field` growing too big. #687
* Identify which fields should contain arrays of values, rather than scalar values. #727, #661

#### Deprecated

Expand Down
2 changes: 1 addition & 1 deletion code/go/ecs/container.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions code/go/ecs/host.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions code/go/ecs/observer.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion code/go/ecs/user.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.