Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance description of event.outcome field #759

Merged
merged 3 commits into from Mar 2, 2020

Conversation

MikePaquette
Copy link
Contributor

Since publishing ECS 1.4, where the ECS categorization fields were introduced, the event.outcome field has generated the most questions about its definition, use, and consistency.

This PR significantly expands the definitions and example usage of event.outcome based on the feedback from the community.

No field names or allowed values are changed with this PR.

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog, even if there's no new fields. I think this clarification deserves a mention in there.

I have some clarifications on the text to suggest, as well as one typo fix. But this is looking good :-)

schemas/event.yml Outdated Show resolved Hide resolved
schemas/event.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmat webmat merged commit c47b604 into elastic:master Mar 2, 2020
dcode pushed a commit to dcode/ecs that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants