Issue/140 show version number #153
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this please |
| from eland._version import * | ||
| from eland._version import ( | ||
| __title__, | ||
| __description__, |
There was a problem hiding this comment.
Looking over this change, I actually much prefer it when the imports are listed out like in the lines above instead of just using the asterisk - it makes it easier to find where things are defined (imho). @sethmlarson is it common practice to do asterisk imports in init.py? I guess it saves some typing, but I've always generally had the feel that asterisk imports in general were frowned upon.
There was a problem hiding this comment.
Yeah star imports are not optimal, makes it hard for tooling to figure out the true signature of objects being used without searching everywhere. I actually have a flake warning suppressed due to this but I'm saving the fix until we narrow our public API so there's no rework to do. :)
Show the version number
The version number was being imported using the following statement:
from eland._version import *This way only loads the non-private names (see this), importing the names implicitly solves the issue.
Add ELLIPSIS, to ignore trailing white-spaces in doctest.
Closes #140