Fix bug with empty dataframe number of rows #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this please |
|
@mesejo Nice! Let me know when you're ready for review. :) |
|
@sethmlarson For my part the only thing I think is missing is refactoring the SizeTask constructor, given that all the class children share the same behavior. Let me know what do you think. |
|
@mesejo That sounds fine to me! Also don't worry about the CI failure, it's a transient error. |
mesejo
changed the title
|
@sethmlarson Feel free to review it when possible |
|
jenkins test this please |
sethmlarson
suggested changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at solving the bug with the wrong shape, instead of only passing the sort field, one could pass the index and query the
lenin the constructor. An enhancement will be to create a unique constructor in SizeTask with the logic.Closes #152