Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isna, notna functions #210

Merged
merged 4 commits into from May 19, 2020
Merged

Add isna, notna functions #210

merged 4 commits into from May 19, 2020

Conversation

mesejo
Copy link
Contributor

@mesejo mesejo commented May 18, 2020 •
edited by sethmlarson

This commits includes:

  1. The basic functionality for isna, notna functions
  2. The documentation
  3. Update pandas docs external links

Closes #184

@mesejo
add isna, notna functions
2e47d5e 
add docs, blacken

update pandas docs links
@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@mesejo mesejo changed the title Add isna, notna functions [WIP] Add isna, notna functions May 18, 2020
sethmlarson
sethmlarson suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @mesejo! Couple of comments for you.

eland/series.py Show resolved Hide resolved
eland/tests/series/test_na_pytest.py Outdated Show resolved Hide resolved
@sethmlarson
Copy link
Contributor

jenkins test this please

@sethmlarson
Copy link
Contributor

Jenkins test this please

sethmlarson
sethmlarson suggested changes May 19, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing!

eland/tests/series/test_na_pytest.py Outdated Show resolved Hide resolved
sethmlarson
sethmlarson approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change myself in GitHub, you may have to do a git pull if you need to work on the branch again FYI

@mesejo
Copy link
Contributor Author

mesejo commented May 19, 2020

@sethmlarson What do you mean?

@mesejo mesejo changed the title [WIP] Add isna, notna functions Add isna, notna functions May 19, 2020
@sethmlarson
Copy link
Contributor

@mesejo I pushed to your branch so you'll have to do a git pull origin feature/184-implement-series-isna locally if you were to work on the branch again. I don't think you'll need to though because this change looks good :)

@sethmlarson
Copy link
Contributor

jenkins test this please

@mesejo
Copy link
Contributor Author

mesejo commented May 19, 2020

I just saw it do you think is good to be merged? I saw there is a new issue for fillna and dropna.

@sethmlarson
Copy link
Contributor

@mesejo Yeah I split them into separate issues because they're two different things really :)

@sethmlarson sethmlarson merged commit 890cf6d into elastic:master May 19, 2020
@sethmlarson
Copy link
Contributor

🎉 Thanks @mesejo! I'm planning on doing a release this week probably tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eland.Series.isna not implemented
3 participants
@mesejo @elasticmachine @sethmlarson