Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for es_if_exists='append' to pandas_to_eland() #217

Merged
merged 1 commit into from Jun 15, 2020

Conversation

sethmlarson
Copy link
Contributor

Adds support for appending a pd.DataFrame to a potentially existing Elasticsearch index.
The verification between mappings currently is pretty strict. All field and data types are compared
and only float types, integer types, date/date-nano, and keyword->text are allowed. We rely on Elasticsearch's own type checking for integer out-of-bounds issues. We're also currently requiring that every column exactly match every entry in the ES mapping, so they must be identical.

Open questions for me:

  • Is being strict about columns/entries correct? Should we be less strict on one side?
  • Am I missing any type compatibilities?
  • Should I remove date-nano -> date since there is a loss of information?

Closes #173

Copy link
Contributor

@stevedodson stevedodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@sethmlarson sethmlarson merged commit f639410 into elastic:master Jun 15, 2020
@sethmlarson sethmlarson deleted the pandas-to-eland-append branch June 15, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "append" mode to pandas_to_eland()
2 participants