[ML] adds support for transforming LGBMRegressor models #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
enhancement
sethmlarson
suggested changes
Aug 6, 2020
There was a problem hiding this comment.
We'll need a few changes to noxfile.py:
- Add the files that are typed to the
TYPED_FILEScollection - Add a section for testing with and without
lightgbmin thetest_ml_depsjob
And one change in setup.py:
- Add the
lightgbmextra so we can version constrain in the future if needed
sethmlarson
suggested changes
Aug 7, 2020
There was a problem hiding this comment.
Handful of nits but now this is ready for a technical review :D Thanks much!
Also, I noticed the version pin to 2.3.X, it looks like a release candidate for v3 got published literally minutes ago. As a separate item I'll open an issue to test against v3 and see if it's easy for us to support both or if its more work.
sethmlarson
approved these changes
Aug 7, 2020
eland/ml/transformers/lightgbm.py
Outdated
| if decider == ">=": | ||
| return "gte" | ||
| raise ValueError( | ||
| "Unsupported splitting decider: %s. Only <=, " "<, >=, and > are allowed." |
There was a problem hiding this comment.
This is two string literals joining together, you can change it to one. (see "...<=, " "<,...")
tveasey
reviewed
Aug 10, 2020
|
Thanks @benwtrent and @tveasey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for lightgbm LGBMRegressor models.
Verified that all the supported objective functions and various booster types work great.
relates to #240