Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFrame.agg() with single non-list aggregation name now returns series #263

Merged
merged 5 commits into from Aug 25, 2020
Merged

DataFrame.agg() with single non-list aggregation name now returns series #263

merged 5 commits into from Aug 25, 2020

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Aug 19, 2020

Closes #235

  • Now non-list aggregation will return series
  • List aggregation works the same.
  • Added Tests

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Aug 24, 2020

@sethmlarson Can you please review this?

sethmlarson
sethmlarson suggested changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, I have an alternate implementation suggestion :)

eland/dataframe.py Outdated Show resolved Hide resolved
sethmlarson
sethmlarson suggested changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on .agg(["mean"]) behavior

@sethmlarson
Copy link
Contributor

jenkins test this please

sethmlarson
sethmlarson approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@sethmlarson sethmlarson merged commit 1d63111 into elastic:master Aug 25, 2020
@V1NAY8 V1NAY8 deleted the issue/235 branch August 26, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataFrame.agg() with single non-list aggregation name returns DataFrame instead of Series
3 participants
@V1NAY8 @elasticmachine @sethmlarson