Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of pandas_to_eland() using parallel_bulk() #279

Merged
merged 2 commits into from Oct 8, 2020

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Oct 5, 2020

PR on #238

@sethmlarson Please check this

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Almost ready to go, I have some comments for you:

eland/etl.py Outdated Show resolved Hide resolved
eland/etl.py Show resolved Hide resolved
eland/etl.py Outdated Show resolved Hide resolved
@sethmlarson
Copy link
Contributor

jenkins test this please

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Oct 8, 2020

Just asking, is it ok for you to add hacktoberfest-accepted label to this PR. No worries, if not added though! 😄

@sethmlarson
Copy link
Contributor

I can do that!

@sethmlarson sethmlarson merged commit 0dd247b into elastic:master Oct 8, 2020
@V1NAY8 V1NAY8 deleted the issue/238 branch October 8, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants