Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document DataFrame.groupby() methods #300

Merged
merged 1 commit into from Oct 27, 2020
Merged

Document DataFrame.groupby() methods #300

merged 1 commit into from Oct 27, 2020

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Oct 26, 2020 •
edited

Closes #293

cc @V1NAY8 because I moved around the agg functions on to DataFrameGroupBy to match pandas and collapsed _groupby_aggs() and aggs_groupby() into one method.

@sethmlarson sethmlarson force-pushed the document-groupby branch 2 times, most recently from eebd2c6 to 775870b Compare October 26, 2020 22:31
@V1NAY8
Copy link
Contributor

V1NAY8 commented Oct 27, 2020

  • Looks Good 😃 Since the Median and MAD have approximate calculations, I think they need to be # doctest: +SKIP.
  • We did the same for DataFrame.median(), DataFrame.mad()

@sethmlarson
Copy link
Contributor Author

Updated, will merge when CI passes. Thanks @V1NAY8 for the eyeballs!

@sethmlarson sethmlarson merged commit ae70f03 into elastic:master Oct 27, 2020
@sethmlarson sethmlarson deleted the document-groupby branch October 27, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document GroupBy functionality in API Reference
2 participants
@sethmlarson @V1NAY8