Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #331

Merged
merged 3 commits into from Jan 4, 2021
Merged

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Nov 24, 2020

Closes #330

  • This PR safely removes deprecations in eland
  • Tests for MLModel are refactored safely.

@sethmlarson Please review 馃槂

This PR can be merged to master when required.

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, love removing stuff! I have a few comments:

tests/ml/test_ml_model_pytest.py Show resolved Hide resolved
tests/ml/test_ml_model_pytest.py Show resolved Hide resolved
eland/ml/ml_model.py Outdated Show resolved Hide resolved
eland/ml/__init__.py Show resolved Hide resolved
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Dec 31, 2020

Made changes, Sorry had to rebase and force push.

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Jan 4, 2021

Cool, CI is good

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sethmlarson sethmlarson merged commit 27717ee into elastic:master Jan 4, 2021
@V1NAY8 V1NAY8 deleted the remove-deprecations branch January 5, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecations in eland
3 participants