Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idx to DataFrame #353

Merged
merged 2 commits into from Jul 28, 2021
Merged

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Jun 7, 2021

Work on #352

  • Implemented the pandas similar functionality
  • Modified noxfile.py similar to urllib3 because existing one is hanging on windows forever

@sethmlarson or @stevedodson Please review :)

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sethmlarson
Copy link
Contributor

Jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Jul 28, 2021

Rebased this, ask jenkins to test this once

@sethmlarson
Copy link
Contributor

jenkins test this please

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments otherwise this looks good!

eland/operations.py Outdated Show resolved Hide resolved
eland/query.py Outdated Show resolved Hide resolved
eland/operations.py Outdated Show resolved Hide resolved
@V1NAY8 V1NAY8 requested a review from sethmlarson July 28, 2021 12:25
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson
Copy link
Contributor

jenkins test this please

@sethmlarson sethmlarson merged commit 4c1af42 into elastic:master Jul 28, 2021
@V1NAY8 V1NAY8 deleted the add-idx-to-dataframe branch July 28, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants