Optimize aggregate_field_name method in field_mappings #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this please |
|
Now, this also closes #251 |
|
@V1NAY8 Could you separate these two feature contributions into different PRs? It's best to keep them separate so they don't get blocked on each other. I'd also like to have the ML change reviewed by someone else. |
sethmlarson
suggested changes
Aug 6, 2021
V1NAY8
force-pushed
the
optimize-aggregatable_name
branch
from
8fb3143
to
e67fe67
Compare
|
jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
aggregatable_field_namehasself._mappings_capabilitieswhich is a dataframe.We are querying
dataframe4 times per method call. Instead query it once and reuse the result.Also this improves readability of the code.
@sethmlarson take a look