Remove PandasToCSVCollector, PandasToDataFrameCollector
#378
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
V1NAY8
changed the title
PandasToCSVCollector, PandasToCSVCollector PandasToCSVCollector, PandasToDataFrameCollector
|
jenkins test this please |
eland/operations.py
Outdated
|
|
||
| return collector._ret | ||
| df = self._es_results(query_compiler, show_progress) | ||
| df.to_csv(**kwargs) |
There was a problem hiding this comment.
return df.to_csv()? We should add a type and test for this.
There was a problem hiding this comment.
So, we actually won't return this, the path of the file is passed in kwargs, where the csv has to be ingested to.
We already have good tests in tests\dataframe\test_to_csv_pytest.py
What do you think ?
There was a problem hiding this comment.
From reading pandas.DataFrame.to_csv() it looks like if path_or_buf is None then the CSV is returned as a string. We should probably do and test that as well.
V1NAY8
force-pushed
the
remove-collectors
branch
from
3d14588
to
dad552a
Compare
|
jenkins test this please |
This PR is a small change that removes
PandasToCSVCollector,PandasToDataFrameCollectorThis has a basic functionality, But at the moment I think its not required.
If any additional functionality comes, I think we can achieve it without a class!
@sethmlarson Take a look at it :)