Yield list of hits instead of individual hits #379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of yielding individual hits from
operations._search_yield_hits()
we should instead yield list of hits which are then sent through_es_results_to_pandas
to transform a list of hits to a single dataframe. We do this mostly because post-processing is more efficient if done on larger dataframes instead of smaller single-hit ones.Related to #369 this will help performance because we won't be doing post-processing on individual dataframes.
cc @V1NAY8 @kxbin