Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield list of hits instead of individual hits #379

Merged
merged 1 commit into from Aug 17, 2021

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Aug 17, 2021

Instead of yielding individual hits from operations._search_yield_hits() we should instead yield list of hits which are then sent through _es_results_to_pandas to transform a list of hits to a single dataframe. We do this mostly because post-processing is more efficient if done on larger dataframes instead of smaller single-hit ones.

Related to #369 this will help performance because we won't be doing post-processing on individual dataframes.

cc @V1NAY8 @kxbin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants