Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Proper DataFrame Formatting when max_rows = 0 #57

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Adds Proper DataFrame Formatting when max_rows = 0 #57

merged 2 commits into from
Nov 20, 2019

Conversation

blaklaybul
Copy link
Contributor

This fixes #56

This also adds the proper "x" character when printing dataframe dimensions.

@blaklaybul blaklaybul added the bug Something isn't working label Nov 19, 2019
@blaklaybul blaklaybul self-assigned this Nov 19, 2019
stevedodson
stevedodson approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@stevedodson stevedodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevedodson stevedodson merged commit 29b6a70 into elastic:master Nov 20, 2019
@blaklaybul blaklaybul deleted the fix-no-results branch November 26, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedodson stevedodson stevedodson approved these changes

Assignees

@blaklaybul blaklaybul

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnboundLocalError Returned for dataframe filters that have no results
2 participants
@blaklaybul @stevedodson