Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkin_pid to CheckinObserved #106

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

fearful-symmetry
Copy link
Contributor

Continuation of elastic/elastic-agent#4083

In order to get elastic-agent to monitor endpoint, we need to know the pid of endpoint, which we currently can't do, as Endpoint operates a bit more independently than the other beats that are talking to agent. Endpoint can restart independently, and Agent can't track the PID on its own.

This adds a checkin_pid integer to CheckinObserved. I put it here for two reason:

  1. I can't think of anywhere else it could go
  2. If endpoint restarts on its own, CheckinObserved seems like the most logical place to put a new PID.

@fearful-symmetry fearful-symmetry self-assigned this Mar 26, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner March 26, 2024 19:05
@fearful-symmetry fearful-symmetry requested review from michalpristas and pchila and removed request for a team March 26, 2024 19:05
elastic-agent-client.proto Outdated Show resolved Hide resolved
Copy link

@brian-mckinney brian-mckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Mar 26, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @fearful-symmetry

@fearful-symmetry fearful-symmetry merged commit 6572e2f into elastic:main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants