Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Upgrade Go to 1.20.5 #321

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Upgrade Go to 1.20.5 #321

merged 2 commits into from
Jul 6, 2023

Conversation

AndersonQ
Copy link
Member

What does this PR do?

Upgrade Go to 1.20.5

Why is it important?

To keep up with the latest Go improvements, features and bug fixes.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

  • N/A

@AndersonQ AndersonQ added enhancement New feature or request Team:Elastic-Agent Label for the Agent team backport-skip 8.10-candidate labels Jul 5, 2023
@AndersonQ AndersonQ requested a review from a team as a code owner July 5, 2023 16:12
@AndersonQ AndersonQ self-assigned this Jul 5, 2023
@AndersonQ AndersonQ requested review from pierrehilbert and cmacknz and removed request for a team July 5, 2023 16:12
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-06T17:49:59.094+0000

  • Duration: 19 min 49 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@cmacknz
Copy link
Member

cmacknz commented Jul 6, 2023

It looks like it didn't build the darwin-aarch64 binary which is weird. There are also no logs. Let's just try it again.

[2023-07-05T16:31:46.138Z] Error: Build: binary check failed: stat build/binaries/elastic-agent-shipper-8.10.0-SNAPSHOT-darwin-aarch64/elastic-agent-shipper: no such file or directory
script returned exit code 1

@cmacknz
Copy link
Member

cmacknz commented Jul 6, 2023

/test

@AndersonQ AndersonQ merged commit a8b8665 into elastic:main Jul 6, 2023
13 checks passed
@AndersonQ AndersonQ deleted the upgrade-go branch July 6, 2023 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
8.10-candidate backport-skip enhancement New feature or request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants