Collect Endpoint Security logs on elastic-agent diagnostics collect command #242
Conversation
AndersonQ
added
Team:Elastic-Agent-Control-Plane
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
run end-to-end tests |
1 similar comment
|
run end-to-end tests |
jlind23
requested review from
a team,
blakerouse and
michel-laterman
and removed request for
a team
|
run end-to-end tests |
AndersonQ
force-pushed
the
105-collect-endpoit-logs
branch
from
79f0218
to
6c1a9f0
Compare
|
@AndersonQ Looking at the fleet-ci/pr-merge this look like an issue with the golint module. Can you take a look? |
|
/test |
| if err != nil { | ||
| return closeHandlers(fmt.Errorf("unable to create log file in archive: %w", err), lf) | ||
|
|
||
| name := strings.TrimPrefix(path, logPath) |
There was a problem hiding this comment.
are endpoint logs in a flat dir? or is there any nesting in subdirs?
There was a problem hiding this comment.
as far as I know, on a flat dir. Why? if there are nested dir it wouldn't work?
There was a problem hiding this comment.
the names will get mangled on Windows if it's nested. Using filepath.ToSlash(strings.TrimPrefix(path, logPath)) will ensure that windows separators are properly converted
|
run end-to-end tests |
…-agent into 105-collect-endpoit-logs
|
The failing test is unrelated to the PR and it's failing for others as well. An issue was created to investigate it |
Fixes #105