-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding kustomize templates for k8s onboarding #4754
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @gizas? 🙏
NOTE: |
...kustomize/onboarding/default/elastic-agent-managed/base/elastic-agent-managed-daemonset.yaml
Outdated
Show resolved
Hide resolved
...gent-kustomize/default/elastic-agent-standalone/base/elastic-agent-standalone-daemonset.yaml
Show resolved
Hide resolved
I am a bit confused. What is the different between |
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the onboarding scenario and everything works as expected ✨
@gizas is the description up-to-date?
there is no |
Sorry typo. Updated |
@gizas one other thing came up about the elastic agent version. Right now in the template, version is set to non-existing 8.15.0. Can we somehow ensure that we always have a valid version there, or alternatively expose it as well as a variable, so for onboarding use-case we can set it on our side? |
@mykolaharmash the way it works is that the Makefile computes the agent image version based on this file: elastic-agent/version/version.go Line 7 in a6dba3d
So all the daemonset file has the elastic-agent:8.15.0 inside. This is the only place where I see that this image exists So i guess another sed like: sed -e "s/elastic-agent:8.15.0/elastic-agent:VERSION/g" can do the magic. Also, I think this is only now a problem until we merge the PR. After that we wont have the problem and the CI will make sure that this is always correct. And the user can choose the version with the following use of ref: |
Updating my answer above, I think needs to be mandatory for kibana UI onboarding to update the link like |
@gizas Just to make sure - is there an automation that there is a version of the template for every stack version? Or is this something that needs to be done manually? We should make sure that this won't break in the next version. |
Yes as part of this PR, I have added this in the ci: |
Got it, thank you! I'll update the onboarding logic so that URL always has the version ref |
@cmacknz or @blakerouse if no other objection can you please approve this? We will need one more to merge |
|
What does this PR do?
WHAT: Introduces the onboarding templates of kustomize for k8s observability
WHY: #4657
Checklist
./changelog/fragments
using the changelog toolHow to test this PR locally
cd elastic-agent-kustomize/default kubectl apply -k elastic-agent-managed or kubectl apply -k elastic-agent-standalone
Examples of online references:
Testing for onboarding procedure
Managed:
Standalone
Eg.
Note: API_KEY should be given as bas64 encoded values from Kibana
Base 64 encoding decding:
Images
Successful enrollement in managed
Successful Installation of kube-state-metrics and
Related issues