Remove deprecated fields from OTel ResolverSettings #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Providers` and `Converters` fields of `ResolverSettings` struct were deprecated in [v0.99.0](https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.99.0) (open-telemetry/opentelemetry-collector#9516) and removed in [v0.101.0](https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.101.0). This refactoring is required before updating to OTel v0.101.0.
|
This pull request does not have a backport label. Could you fix it @andrzej-stencel? 🙏
NOTE: |
andrzej-stencel
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
ycombinator
requested review from
ChrsMark and
michel-laterman
and removed request for
michalpristas and
leehinman
|
ycombinator
approved these changes
May 28, 2024
michalpristas
pushed a commit
that referenced
this pull request
Jun 21, 2024
The `Providers` and `Converters` fields of `ResolverSettings` struct were deprecated in [v0.99.0](https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.99.0) (open-telemetry/opentelemetry-collector#9516) and removed in [v0.101.0](https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.101.0). This refactoring is required before updating to OTel v0.101.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the deprecated
ProvidersandConvertersfields ofResolverSettingsstruct withProviderFactoriesandConverterFactories.The fields were deprecated in OTel v0.99.0 (PR: open-telemetry/opentelemetry-collector#9516) and removed in v0.101.0.
Why is it important?
This refactoring is required before updating to OTel v0.101.0.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E test