You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is the path taken when a groupId is applied. But when a yScaleis defined, it renders the outside only if x0 and x1 where initially undefined, this is the problem!
Describe the issue
If a
RectAnnotation
is defined without using agroupId
theoutside
prop has no affect.To Reproduce
Steps to reproduce the behavior:
groupId
on theRectAnnotation
specoutside
annotation whengroupId
is missingExpected behaviour
The
RectAnnotation
is always rendered on the outside of the chart when theoutside
prop is set totrue
.Screenshots
![image](https://private-user-images.githubusercontent.com/19007109/341874562-913c1b4b-ef16-4d6e-865c-98d730c81c81.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2OTc2ODcsIm5iZiI6MTcyNDY5NzM4NywicGF0aCI6Ii8xOTAwNzEwOS8zNDE4NzQ1NjItOTEzYzFiNGItZWYxNi00ZDZlLTg2NWMtOThkNzMwYzgxYzgxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDE4MzYyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhMTJjOTg3ZTMxMzQzMzcxY2Y5ZDM2MjhkNzliNmE0MDA0NTZkYWZiNjIxYjUzYjE2ZjM2YmU0ZjllYjg0M2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bu5LDj6MvALf9Ex1HN7d-yAY-CnKx7nBfzNwLH9K8iM)
Version (please complete the following information):
I think this issue is original to the
outside
feature added in #1207Additional context
The code has a break branch from #842 to render annotations when we have no
yScale
.elastic-charts/packages/charts/src/chart_types/xy_chart/annotations/rect/dimensions.ts
Line 75 in ae2af1c
This is the path taken when a
groupId
is applied. But when ayScale
is defined, it renders the outside only ifx0
andx1
where initiallyundefined
, this is the problem!elastic-charts/packages/charts/src/chart_types/xy_chart/annotations/rect/dimensions.ts
Lines 129 to 134 in ae2af1c
The text was updated successfully, but these errors were encountered: