fix: handle splitted series with group value to 0 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation wrongly interpret a zero value in the colorValues list of a legend item as a single series. This cause that series to be named with the spec name or the spec id. Instead a splitted series with a group value of zero, should be threated in the same way as anyother splitted series, using the group value as the series name fix elastic#288
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 98.17% 98.23% +0.05%
==========================================
Files 37 37
Lines 2682 2996 +314
Branches 617 740 +123
==========================================
+ Hits 2633 2943 +310
- Misses 44 46 +2
- Partials 5 7 +2
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Aug 6, 2019
|
🎉 This PR is included in version 9.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
7 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [9.0.1](elastic/elastic-charts@v9.0.0...v9.0.1) (2019-08-07) ### Bug Fixes * handle splitted series with group value to 0 ([opensearch-project#289](elastic/elastic-charts#289)) ([82c698f](elastic/elastic-charts@82c698f)), closes [opensearch-project#288](elastic/elastic-charts#288)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation wrongly interpret a zero value in the colorValues list of a legend item
as a single series. This cause that series to be named with the spec name or the spec id. Instead a splitted series with a group value of zero, should be threated in the same way as anyother splitted series, using the group value as the series name
fix #288
from
to
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials