Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] ciGroup1 func test fixes #288

Merged
merged 1 commit into from
Apr 15, 2021
Merged

[Tests] ciGroup1 func test fixes #288

merged 1 commit into from
Apr 15, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 14, 2021

Description

This includes tests when running the following:
node scripts/functional_tests.js --config test/functional/config.js --include ciGroup1

One fix related to the source code and had to ignore the other code to move onto later.
Will return with [FIXME], basically it works when actually running the application.
It's just not loading the data in and failing because it has no clue about the logstash-*
index pattern.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

1/12 of #247

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@odfe-release-bot
Copy link

✅   DCO Check Passed f91033b

@odfe-release-bot
Copy link

✅   DCO Check Passed 3be895a

@kavilla kavilla requested a review from mihirsoni April 14, 2021 22:15
This includes tests when running the following:
node scripts/functional_tests.js --config test/functional/config.js --include ciGroup1

One fix related to the source code and had to ignore the other code to move onto later.
Will return with [FIXME], basically it works when actually running the application.
It's just not loading the data in and failing because it has no clue about the logstash-*
index pattern.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed e67b7eb

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@peterzhuamazon
Copy link
Member

start dco check

@odfe-release-bot
Copy link

✅   DCO Check Passed e67b7eb

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavilla kavilla merged commit c9b5315 into main Apr 15, 2021
@kavilla kavilla deleted the kavilla/update-func-test branch April 15, 2021 20:13
kavilla added a commit that referenced this pull request May 21, 2021
This includes tests when running the following:
node scripts/functional_tests.js --config test/functional/config.js --include ciGroup1

One fix related to the source code and had to ignore the other code to move onto later.
Will return with [FIXME], basically it works when actually running the application.
It's just not loading the data in and failing because it has no clue about the logstash-*
index pattern.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants