-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] ciGroup1 func test fixes #288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ DCO Check Passed f91033b |
mihirsoni
reviewed
Apr 14, 2021
src/plugins/timeline/public/directives/timeline_help/timeline_help.html
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Apr 14, 2021
mihirsoni
reviewed
Apr 14, 2021
kavilla
force-pushed
the
kavilla/update-func-test
branch
from
April 14, 2021 18:36
f91033b
to
3be895a
Compare
✅ DCO Check Passed 3be895a |
This includes tests when running the following: node scripts/functional_tests.js --config test/functional/config.js --include ciGroup1 One fix related to the source code and had to ignore the other code to move onto later. Will return with [FIXME], basically it works when actually running the application. It's just not loading the data in and failing because it has no clue about the logstash-* index pattern. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
force-pushed
the
kavilla/update-func-test
branch
from
April 15, 2021 01:08
3be895a
to
e67b7eb
Compare
✅ DCO Check Passed e67b7eb |
mihirsoni
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
start dco check |
✅ DCO Check Passed e67b7eb |
boktorbb
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kavilla
added a commit
that referenced
this pull request
May 21, 2021
This includes tests when running the following: node scripts/functional_tests.js --config test/functional/config.js --include ciGroup1 One fix related to the source code and had to ignore the other code to move onto later. Will return with [FIXME], basically it works when actually running the application. It's just not loading the data in and failing because it has no clue about the logstash-* index pattern. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes tests when running the following:
node scripts/functional_tests.js --config test/functional/config.js --include ciGroup1
One fix related to the source code and had to ignore the other code to move onto later.
Will return with [FIXME], basically it works when actually running the application.
It's just not loading the data in and failing because it has no clue about the logstash-*
index pattern.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
1/12 of #247
Check List