Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDomain should fallback to ordinal type #678

Closed
nickofthyme opened this issue May 14, 2020 · 1 comment · Fixed by #704 or elastic/kibana#69126
Closed

XDomain should fallback to ordinal type #678

nickofthyme opened this issue May 14, 2020 · 1 comment · Fixed by #704 or elastic/kibana#69126
Assignees
Labels
:axis Axis related issue bug Something isn't working released Issue released publicly :vislib Relating to vislib replacement :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented May 14, 2020

Describe the bug
Using a LineSeries when defining an XScaleType as linear or undefined, elastic charts will try to use linear and use ordinal as a fallback if needed. This should be the same logic with AreaSeries.

Version (please complete the following information):

  • OS: macOS
  • Browser: chrome
  • Elastic Charts: latest

Additional context
Related to code below...

if (!isNumberArray(values)) {
throw new Error(
`Each X value in a ${mainXScaleType.scaleType} x scale needs be be a number. String or objects are not allowed`,
);
}

Errors in browser console

Uncaught Error: Each X value in a linear x scale needs be be a number. String or objects are not allowed
    at Object.mergeXDomain (x_domain.js:51)
    at Object.computeSeriesDomains (utils.js:136)
    at compute_series_domains.js:14
    at resultFuncWithRecomputations (index.js:77)
    at index.js:70
    at index.js:30
    at index.js:84
    at index.js:30
    at selector (index.js:105)
    at index.js:80
@nickofthyme nickofthyme added bug Something isn't working :axis Axis related issue :vislib Relating to vislib replacement labels May 14, 2020
@nickofthyme nickofthyme self-assigned this May 14, 2020
@markov00 markov00 added the :xy Bar/Line/Area chart related label May 29, 2020
@markov00 markov00 added this to Backlog in Vislib replacement via automation May 29, 2020
@markov00 markov00 moved this from Backlog to June plan in Vislib replacement May 29, 2020
Vislib replacement automation moved this from June plan to Done Jun 15, 2020
markov00 pushed a commit that referenced this issue Jun 16, 2020
## [19.5.1](v19.5.0...v19.5.1) (2020-06-16)

### Bug Fixes

* graceful scale fallbacks and warnings ([#704](#704)) ([ed49bbb](ed49bbb)), closes [#678](#678)
* **axis:** rotated label positioning ([#709](#709)) ([2e26430](2e26430)), closes [#673](#673)
* **tooltip:** popper scroll issue ([#712](#712)) ([0c97c67](0c97c67))
@markov00
Copy link
Member

🎉 This issue has been resolved in version 19.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:axis Axis related issue bug Something isn't working released Issue released publicly :vislib Relating to vislib replacement :xy Bar/Line/Area chart related
Projects
No open projects
2 participants