Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pie chart vislib replacement functional tests #917

Closed
9 tasks done
stratoula opened this issue Nov 25, 2020 · 1 comment · Fixed by #1117 or elastic/kibana#97005
Closed
9 tasks done

Pie chart vislib replacement functional tests #917

stratoula opened this issue Nov 25, 2020 · 1 comment · Fixed by #1117 or elastic/kibana#97005
Assignees
@monfera
Labels
enhancement New feature or request :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly :vislib Relating to vislib replacement
Projects
Vislib piechart migration

Comments

@stratoula
Copy link

stratoula commented Nov 25, 2020 •
edited by markov00
Loading

Is your feature request related to a problem? Please describe.
As we are going to proceed on replacing the vislib pie chart with the elastic charts implementation, there is the need to retrieve some data in order the functional tests to work properly.

Data that we need in order the vislib functional tests to run:

  • Number of slices
  • Slices Labels (array of strings)
  • Slices Values (array of strings)
  • Get slices colors (array of hex strings).
  • Get all legends (and the nested ones) (array of strings)
  • I want to be able to click on a specific slice (i.e. filterOnPieSlice('Other')) to test the click event (filtering)
  • I want to be able to click on a specific legend action(i.e. filterLegendAction('Other)) to test the action (filtering)
  • I want to get the color of a specific slice (i.e. getPieSliceStyle('Other')
  • Get the value of a specific slice
@stratoula stratoula added meta ...meta issue :vislib Relating to vislib replacement :partition Partition/PieChart/Donut/Sunburst/Treemap chart related labels Nov 25, 2020
@dej611 dej611 mentioned this issue Dec 1, 2020
Closed
This was referenced Dec 22, 2020
Closed
Merged
@markov00 markov00 changed the title [meta] Pie chart vislib replacement functional tests Pie chart vislib replacement functional tests Apr 7, 2021
@markov00 markov00 added enhancement New feature or request and removed meta ...meta issue labels Apr 7, 2021
@markov00 markov00 mentioned this issue Apr 13, 2021
Merged
3 tasks
@markov00 markov00 moved this from To do to In progress in Vislib piechart migration Apr 13, 2021
Vislib piechart migration automation moved this from In progress to Done Apr 15, 2021
markov00 added a commit that referenced this issue Apr 15, 2021
@markov00
feat(partition): add debuggable state (#1117)
d7fc206 
Add the debug state for partition charts with the following type signature:

fix #917
nickofthyme pushed a commit that referenced this issue Apr 15, 2021
@semantic-release-bot
chore(release): 28.2.0 [skip ci]
8017edd 
# [28.2.0](v28.1.0...v28.2.0) (2021-04-15)

### Bug Fixes

* **xy:** consider `useDefaultGroupDomain` on scale config ([#1119](#1119)) ([c1b59f2](c1b59f2)), closes [#1087](#1087)

### Features

* **a11y:** allow user to pass custom description for screen readers ([#1111](#1111)) ([2ee1b91](2ee1b91)), closes [#1097](#1097)
* **partition:** add debuggable state ([#1117](#1117)) ([d7fc206](d7fc206)), closes [#917](#917)
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 28.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 15, 2021
@nickofthyme nickofthyme mentioned this issue Apr 15, 2021
Merged
1 task
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 28.2.0 [skip ci]
ac1d806 
# [28.2.0](elastic/elastic-charts@v28.1.0...v28.2.0) (2021-04-15)

### Bug Fixes

* **xy:** consider `useDefaultGroupDomain` on scale config ([opensearch-project#1119](elastic/elastic-charts#1119)) ([269ff1a](elastic/elastic-charts@269ff1a)), closes [opensearch-project#1087](elastic/elastic-charts#1087)

### Features

* **a11y:** allow user to pass custom description for screen readers ([opensearch-project#1111](elastic/elastic-charts#1111)) ([a0020ba](elastic/elastic-charts@a0020ba)), closes [#1097](elastic/elastic-charts#1097)
* **partition:** add debuggable state ([opensearch-project#1117](elastic/elastic-charts#1117)) ([08f8baf](elastic/elastic-charts@08f8baf)), closes [opensearch-project#917](elastic/elastic-charts#917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monfera monfera

Labels
enhancement New feature or request :partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly :vislib Relating to vislib replacement
Projects
No open projects
Vislib piechart migration
  
Done
Milestone
No milestone
4 participants
@markov00 @monfera @stratoula @nickofthyme