Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless conditional #449

Merged
merged 2 commits into from Nov 15, 2019
Merged

chore: remove useless conditional #449

merged 2 commits into from Nov 15, 2019

Conversation

pedroprado010
Copy link
Contributor

Summary

Removed this conditional, since its already done here.

Checklist

- [ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
- [ ] Unit tests were updated or added to match the most common scenarios
- [ ] Each commit follows the convention

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@codecov-io
Copy link

codecov-io commented Nov 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@898a33f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #449   +/-   ##
=========================================
  Coverage          ?   77.91%           
=========================================
  Files             ?       81           
  Lines             ?     4189           
  Branches          ?      891           
=========================================
  Hits              ?     3264           
  Misses            ?      913           
  Partials          ?       12
Impacted Files Coverage Δ
src/chart_types/xy_chart/domains/x_domain.ts 98.78% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898a33f...09a5672. Read the comment docs.

@markov00 markov00 self-requested a review November 6, 2019 14:51
@markov00 markov00 added the chore label Nov 6, 2019
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, everything looks fine for me.
Let's me run the CI and we will merge it soon

@markov00
Copy link
Member

markov00 commented Nov 6, 2019

jenkins test this

@markov00 markov00 changed the title Removed useless conditional chore: remove useless conditional Nov 6, 2019
@markov00 markov00 merged commit 7738aa9 into elastic:master Nov 15, 2019
@markov00
Copy link
Member

markov00 commented Nov 15, 2019

Thank you @pedroprado010 for your contribution ❤️ ! Will be shipped with the next release

@markov00
Copy link
Member

🎉 This PR is included in version 14.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants