New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove useless conditional #449
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=========================================
Coverage ? 77.91%
=========================================
Files ? 81
Lines ? 4189
Branches ? 891
=========================================
Hits ? 3264
Misses ? 913
Partials ? 12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, everything looks fine for me.
Let's me run the CI and we will merge it soon
jenkins test this |
Thank you @pedroprado010 for your contribution ❤️ ! Will be shipped with the next release |
🎉 This PR is included in version 14.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Removed this conditional, since its already done here.
Checklist
- [ ] Any consumer-facing exports were added tosrc/index.ts
(and stories only import from../src
except for test data & storybook)- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Proper documentation or storybook story was added for features that require explanation or tutorials- [ ] Unit tests were updated or added to match the most common scenarios- [ ] Each commit follows the convention