Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to upload packages directly to Kibana/Fleet #1084

Closed
ruflin opened this issue Dec 29, 2022 · 7 comments · Fixed by #1163
Closed

Add support to upload packages directly to Kibana/Fleet #1084

ruflin opened this issue Dec 29, 2022 · 7 comments · Fixed by #1163
Assignees
Labels
Team:Ecosystem Label for the Packages Ecosystem team

Comments

@ruflin
Copy link
Member

ruflin commented Dec 29, 2022

In elastic/kibana#70582 the Fleet team is working on adding an API to support uploading packages directly to Kibana. elastic-package should have a command available that allows to use this API. The initial idea I had was:

elastic-package upload --kibana=http://localhost:5601

In case this is run inside a package, the package is built and then uploaded to Kibana. Alternatively if a package zip file already exists, the following could be used:

elastic-package upload --path=/foo/bar/package.zip --kibana=http://localhost:5601

In this scenario, elastic-package assumes the package inside the zip file is already validated.

@jsoriano
Copy link
Member

jsoriano commented Jan 9, 2023

We have the elastic-package install command to install packages, should we update this subcommand instead of adding a new one? Having two for the same thing may be confusing.

@ruflin
Copy link
Member Author

ruflin commented Jan 9, 2023

No strong opinion on my end around naming, the above is not necessarily a proposal on how we should name things and structure the params, much more to explain it.

For everyone curious on what the install command does:

The command uses Kibana API to install the package in Kibana. The package must be exposed via the Package Registry.

@amitkanfer
Copy link

@juliaElastic is this related to elastic/kibana#148599 ?

@ruflin ruflin added the Team:Ecosystem Label for the Packages Ecosystem team label Feb 22, 2023
@juliaElastic
Copy link

@amitkanfer Yes, this is a planned improvement in elastic-package to support the upload command. It is for convenience to call the Fleet API.

@jsoriano
Copy link
Member

Once we have this, #1157 can be a low hanging fruit. #1157 will help with development experience and reliability.

@mrodm
Copy link
Contributor

mrodm commented Feb 23, 2023

This issue could be done in different steps:

@mrodm mrodm self-assigned this Feb 23, 2023
@jlind23 jlind23 linked a pull request Feb 27, 2023 that will close this issue
@jlind23
Copy link
Collaborator

jlind23 commented Feb 28, 2023

@mrodm If you have could you please think about recording a demo for this? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants