Add package version 3 guidance for legacy visualization errors #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
reviewed
Sep 29, 2023
| from the dashboard panel context menu or by clicking "Edit visualization in Lens" | ||
| after opening the visualization in the editor. | ||
|
|
||
| The legacy "input-control-vis" must also be replaced by the new [dashboard controls](https://www.elastic.co/guide/en/kibana/current/add-controls.html). |
There was a problem hiding this comment.
These visualizations are the ones allowed in this PR elastic/package-spec#619 ?
It could be removed, but I guess it also gives some hint to remove those visualizations. What do you prefer to do here @drewdaemon ?
There was a problem hiding this comment.
Good point! I added those to the exceptions.
mrodm
approved these changes
Sep 29, 2023
💚 Build Succeeded
History
|
mrodm
deleted the
add-guidance-for-legacy-visualizations-in-package-spec-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds guidance as a follow-up to elastic/package-spec#610