-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logstash Improvements. #1637
Logstash Improvements. #1637
Conversation
@bhapas, I need your (or any of team member's) help for followings:
Thanks. |
/test |
Do you have more details about this? Is this going to be to test logstash or to test packages?
There seems to be a regression in the docker pre-installation in the image used in CI. We are trying to downgrade it in #1639, once merged try to update the branch. |
Thanks for heads up. I highly appreciate If you can please review this change and let us know the release plan. We will use the release distro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you please try to update the branch to have a green CI?
@@ -170,13 +170,14 @@ services: | |||
interval: 60s | |||
timeout: 50s | |||
retries: 5 | |||
command: bash -c "bin/logstash-plugin install logstash-filter-elastic_integration && logstash -f /usr/share/logstash/pipeline/logstash.conf" | |||
command: bash -c 'if [[ ! $(bin/logstash-plugin list) == *"logstash-filter-elastic_integration"* ]]; then echo "Missing plugin logstash-filter-elastic_integration, installing now" && bin/logstash-plugin install logstash-filter-elastic_integration; fi && bin/logstash -f /usr/share/logstash/pipeline/logstash.conf' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to move this to a script if we continue adding things here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One we package the plugin (soon with this PR), we can actually remove this script, no need.
…plugin if not bundled.
5027cc3
to
4f1422b
Compare
buildkite test this |
💚 Build Succeeded
History
cc @mashhurs |
Description
elastic_integration
plugin with Logstash and from LS 8.13 (planned) Logstash carries specific versions of the plugin. If we always install the plugin when LS container starts, we may lose the compatibility issue since it always installs the recent one. Introducing a logic to check if plugin is not bundled yet and install if so.How to test
make build
./elastic-package stack up -d
curl localhost:9600/_node/stats?pretty
. It should show current LS node stats.