Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: minor undici tuning #41

Merged
merged 2 commits into from
Feb 21, 2022
Merged

perf: minor undici tuning #41

merged 2 commits into from
Feb 21, 2022

Conversation

ronag
Copy link
Contributor

@ronag ronag commented Feb 21, 2022

No description provided.

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 21, 2022 •
edited
Loading

💚 CLA has been signed

@ronag
Copy link
Contributor Author

ronag commented Feb 21, 2022

Signed.

delvedor
delvedor requested changes Feb 21, 2022
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!
It looks like the new timeout is breaking some test. Can you add await client.close() at the end of each test here? Thanks!

@ronag ronag requested a review from delvedor February 21, 2022 17:44
delvedor
delvedor approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@delvedor delvedor merged commit 0d559ed into elastic:main Feb 21, 2022
delvedor pushed a commit that referenced this pull request Feb 21, 2022
@ronag @delvedor
perf: minor undici tuning (#41)
3f76eed
delvedor pushed a commit that referenced this pull request Feb 21, 2022
@ronag @delvedor
perf: minor undici tuning (#41)
64c7c20
@delvedor delvedor mentioned this pull request Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
backport 8.0 backport 8.1 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronag @delvedor