[HttpConnection] Handles malformed HTTP (HEAD) responses #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
approved these changes
Aug 10, 2023
JoshMock
approved these changes
Aug 10, 2023
@JoshMock, I tested the issue in this code snippet: const elasticsearch = require('@elastic/elasticsearch');
const net = require('net');
const HOST = 'http://localhost:8080';
function createTcpServer() {
const server = net.createServer();
server.on('connection', (socket) => {
socket.write(`HTTP/1.1 200 OK\r\n`)
socket.write(`Content-Type: text/html\r\n`)
socket.write(`Content-Length: 155\r\n`)
socket.write(`\r\n`)
socket.write(`<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
</head>
<body>
<h1>Hi there</h1>
<p>This is a bad implementation of an HTTP server</p></body>
</html>`)
socket.end()
})
return new Promise((resolve) => server.listen(8080, resolve));
}
async function main() {
await createTcpServer();
try {
console.info('Running Elasticsearch.ping...');
const esClient = new elasticsearch.Client({
nodes: [HOST],
username: '',
password: '',
ssl: { verificationMode: 'none' },
Connection: elasticsearch.HttpConnection,
ConnectionPool: elasticsearch.ClusterConnectionPool,
});
await esClient.ping();
console.info('Ping succeeded');
} catch (err) {
console.error('Elasticsearch.ping', err);
}
}
main();
// Keep the program running forever to make it super-obvious when it crashes.
setInterval(() => { }, 1000)Changing the Connection to |
This was referenced Aug 10, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We learned that attempting to perform a HEAD request to an HTTP server that doesn't comply with the HTTP spec may lead to crashing the app.
This is because the HTTP client cleans the
errorlistener of therequestobject once we receive the response object, but Node.js emits the malformed error on the request object.This PR adds a no-op handler to silence those spec-parse errors.
Testing
To prove the fix works, comment line 132 in
src/connection/HttpConnection.tsand see how the test crashes.