Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdist is missing tests #119

Closed
mtelka opened this issue Sep 26, 2023 · 1 comment · Fixed by #122
Closed

sdist is missing tests #119

mtelka opened this issue Sep 26, 2023 · 1 comment · Fixed by #122
Labels
good first issue Good for newcomers

Comments

@mtelka
Copy link

mtelka commented Sep 26, 2023

The sdist package at PyPI is missing tests. Please add tests to sdist to make downstream testing easier. Thank you.
@pquentin pquentin added the good first issue Good for newcomers label Sep 27, 2023
@pquentin
Copy link
Member

Hello! The Python community appears to be divided over this and there's no current recommendation to include tests or docs (see https://discuss.python.org/t/should-sdists-include-docs-and-tests/14578/115) so I won't be working on this, sorry. That said, I would accept a pull request that implements this.

parona-source added a commit to parona-source/elastic-transport-python that referenced this issue Sep 28, 2023
@parona-source
include tests in sdist and exclude tests in wheels
acec734 
Closes elastic#119

Signed-off-by: Alfred Wingate <parona@protonmail.com>
@parona-source parona-source mentioned this issue Sep 28, 2023
Merged
parona-source added a commit to parona-source/elastic-transport-python that referenced this issue Sep 28, 2023
@parona-source
include tests in sdist and exclude tests in wheels
78b27a7 
Closes elastic#119

Signed-off-by: Alfred Wingate <parona@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include tests in sdist and exclude tests in wheels parona-source/elastic-transport-python
2 participants
@pquentin @mtelka