Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 8.4.1 #116

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Bump version to 8.4.1 #116

merged 3 commits into from
Sep 19, 2023

Conversation

JoshMock
Copy link
Member

Prep the repo to release 8.4.1 with the fix in #112.

pquentin
pquentin reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've fixed the Read the Docs build in #117.

Should we mention #100 too?

@JoshMock
Copy link
Member Author

Good idea. Added a mention of the fix from #100 to the changelog. Also merged #117 to ensure it gets included.

pquentin
pquentin approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating! LGTM.

@JoshMock JoshMock merged commit e32531a into main Sep 19, 2023
18 checks passed
@JoshMock JoshMock deleted the version-fix branch September 19, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoshMock @pquentin