Stop mixing body and parameters in UpdateByQuery (#1702)

elastic · Feb 8, 2024 · 40e1632 · 40e1632
1 parent 6ab664d
commit 40e1632
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/elasticsearch_dsl/update_by_query.py b/elasticsearch_dsl/update_by_query.py
@@ -154,6 +154,6 @@ def execute(self):
 
         self._response = self._response_class(
             self,
-            es.update_by_query(index=self._index, body=self.to_dict(), **self._params),
+            es.update_by_query(index=self._index, **self.to_dict(), **self._params),
         )
         return self._response
diff --git a/tests/test_update_by_query.py b/tests/test_update_by_query.py
@@ -141,9 +141,7 @@ def test_params_being_passed_to_search(mock_client):
     ubq = ubq.params(routing="42")
     ubq.execute()
 
-    mock_client.update_by_query.assert_called_once_with(
-        index=None, body={}, routing="42"
-    )
+    mock_client.update_by_query.assert_called_once_with(index=None, routing="42")
 
 
 def test_overwrite_script():