Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected documentation of sort option #1773

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Corrected documentation of sort option #1773

merged 1 commit into from
Apr 11, 2024

Conversation

miguelgrinberg
Copy link
Collaborator

Fixes #1318

pquentin
pquentin approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg merged commit 0c0bdb7 into elastic:main Apr 11, 2024
15 checks passed
@miguelgrinberg miguelgrinberg deleted the faceted-search-docs-fix branch April 11, 2024 09:40
@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Apr 29, 2024
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@miguelgrinberg @github-actions
Corrected documentation of sort option (#1773)
fb9fae3 
Fixes #1318

(cherry picked from commit 0c0bdb7)
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Merged
miguelgrinberg added a commit that referenced this pull request Apr 29, 2024
@miguelgrinberg
Corrected documentation of sort option (#1773)
9feeb0f 
Fixes #1318

(cherry picked from commit 0c0bdb7)
miguelgrinberg added a commit that referenced this pull request Apr 29, 2024
@github-actions @miguelgrinberg
Corrected documentation of sort option (#1773) (#1792)
7e30592 
Fixes #1318

(cherry picked from commit 0c0bdb7)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.x Backport to 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FacetedSearch does not accept sort configuration
2 participants
@miguelgrinberg @pquentin