Global Aggregations

[kbredemeier]

The following code raises an SystemStackError:

search do
  aggregation :all do
    global
    aggregation :foo do
      terms field: "bar"
    end
  end
end

What I would like to archive is the following:

"aggregations": {
   "all": {
       "global": {},
       "aggregations": {
           "foo": {
               "terms": {
                   "field": "bar"
               }
           }
       }
   }
}

The exception results from nesting the aggregations. Am I using it wrong or is this just not implemented yet?

I looked further into this: Since the global aggregation is structurally similar to a nested aggregation I thought it should be used like one:

search do
  aggregation :all do
    global do
      aggregation :foo do
        terms field: "bar"
      end
    end
  end
end

But this leads to an other error. aggregation is not defined. By comparing the Global class with the Nested class I noticed that Global includes BaseComponent while Nested includes BaseAggregationComponent. Currently I am working around this by monkeypatching the Global class and including BaseAggregationComponent.

I would love to create a pull request if this is the intended way of using the gloabl aggregation.

[karmi]

Hi, yes, I think you're right and this is an oversight on part of the implementation -- making the global method take the block seems like the correct way. Do you feel like creating the pull request?

(Sorry for such a delayed response!, I was tied with something else...)

[gmile]

@karmi now that elastic/elasticsearch-ruby#228 is merged, this should be closed?

[karmi]

@gmile Yes, absolutely, thanks for the ping! And thanks for the other PRs and comments, will try to have a look at them this week!