-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Aggregations #4
Comments
Hi, yes, I think you're right and this is an oversight on part of the implementation -- making the (Sorry for such a delayed response!, I was tied with something else...) |
Changed global aggregation to behave like a nested aggregation Related: #213 Closes #228
…e global aggregation Related: #213, #228
@karmi now that elastic/elasticsearch-ruby#228 is merged, this should be closed? |
@gmile Yes, absolutely, thanks for the ping! And thanks for the other PRs and comments, will try to have a look at them this week! |
Changed global aggregation to behave like a nested aggregation Related: #213 Closes #228
…e global aggregation Related: #213, #228
The following code raises an
SystemStackError
:What I would like to archive is the following:
The exception results from nesting the aggregations. Am I using it wrong or is this just not implemented yet?
I looked further into this: Since the global aggregation is structurally similar to a nested aggregation I thought it should be used like one:
But this leads to an other error.
aggregation
is not defined. By comparing theGlobal
class with theNested
class I noticed thatGlobal
includesBaseComponent
whileNested
includesBaseAggregationComponent
. Currently I am working around this by monkeypatching theGlobal
class and includingBaseAggregationComponent
.I would love to create a pull request if this is the intended way of using the gloabl aggregation.
The text was updated successfully, but these errors were encountered: