Bug in WritableUtils.fromWritable() - incorrect ArrayWritable to List handling

[tzolov]

The ArrayWritable to List transformation does not return the result list but falls back to the byte array:

       else if (writable instanceof ArrayWritable) {
            Writable[] writables = ((ArrayWritable) writable).get();
            List<Object> list = new ArrayList<Object>(writables.length);
            for (Writable wrt : writables) {
                list.add(fromWritable(wrt));
            }
+            return list;
        }
....
        // fall-back to bytearray
        return org.apache.hadoop.io.WritableUtils.toByteArray(writable);
}

[tzolov]

just pushed a fix along with a test #38

[tzolov]

haven't test it but seems like this issue could cause #36 as well.

[costin]

Thanks for the report - it was spot on. I've added some unit tests as well to double check the rest of the conversion (which looks okay).