Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

significant terms aggregation missing regex include method #85

Closed
tatarco opened this issue Dec 29, 2021 · 2 comments
Closed

significant terms aggregation missing regex include method #85

tatarco opened this issue Dec 29, 2021 · 2 comments
Labels
Area: Specification Related to the API spec used to generate client code v7.17.3 v8.2.0

Comments

@tatarco
Copy link

tatarco commented Dec 29, 2021

Hello,
by documentation of SignificantTermsAggregation should support regex aggregation
Documentation

The object new TermsAggregation.Builder() is missing the include method that supports it
it only has
public final Builder include(String value) when for exclude the currect implemtation exists (TermsExclude exclude)

it's expected that the object will have
private final TermsInclude include;
as in TermsAggregation.Builder

not having it causes the wrong behavior and elastic to not use regex for filtering

@swallez
Copy link
Member

swallez commented Mar 21, 2022

This is a problem in the API specification used to produce the Java code: an issue has been opened at elastic/elasticsearch-specification#1553

Once the API spec has been fixed, this issue will be resolved in the next minor release.

@swallez
Copy link
Member

swallez commented May 2, 2022

Java code has been updated, this is included in 7.17.3 and will be in the upcoming 8.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Specification Related to the API spec used to generate client code v7.17.3 v8.2.0
Projects
None yet
Development

No branches or pull requests

2 participants